Listview isn't updating in Fragment

Issue

I know for sure that the updateFromDatabase() function works, I've used print statements to see that the entries put into mCoordinatesArray are there and not empty strings. However when I restart the app, the fragment never populates the list view with items in the database. I think it has something to do with the Fragment Lifecycle, but I have no idea.

Additionally, when I don't restart the app and run it for the first time the list view runs fine. When I rotate or restart the app, the list view no longer populates.

public class LocalFragment extends Fragment{

private ListView mLocalList;
private ArrayAdapter<String> adapter;
private ArrayList<String> mCoordinatesArray;
private BroadcastReceiver mBroadcastReceiver;
private LocationBaseHelper mDatabase;
private DateFormat dateFormat;
private String dateString;

@Override
public void onCreate(Bundle savedInstanceState){
    super.onCreate(savedInstanceState);
}

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState){
    View v = inflater.inflate(R.layout.fragment_local,container,false);
    // SQLite Setup
    mDatabase = new LocationBaseHelper(getActivity());

    mLocalList = (ListView) v.findViewById(R.id.lv_local);
    mCoordinatesArray = new ArrayList<>();
    adapter = new ArrayAdapter<String>(getActivity(), android.R.layout.simple_list_item_1, mCoordinatesArray);
    if(!mDatabase.size().equals("0")){
        updateFromDatabase();
    }
    mLocalList.setAdapter(adapter);
    return v;
}

@Override
public void onResume() {
    super.onResume();

    if(mBroadcastReceiver == null){
        mBroadcastReceiver = new BroadcastReceiver() {
            @Override
            public void onReceive(Context context, Intent intent) {
                dateFormat = new SimpleDateFormat("MM/dd HH:mm:ss a");
                dateString = dateFormat.format(new Date());

                String[] data = intent.getStringExtra("coordinates").split(" ");
                mDatabase.insertEntry(dateString,data[0],data[1]);
                System.out.println(mDatabase.size());

                mCoordinatesArray.add(dateString + " " + data[0] + " " + data[1]);
                adapter.notifyDataSetChanged();
            }
        };
    }
    getActivity().registerReceiver(mBroadcastReceiver, new IntentFilter("location_update"));
}

@Override
public void onDestroy() {
    super.onDestroy();
    if(mBroadcastReceiver!=null){
        getActivity().unregisterReceiver(mBroadcastReceiver);
    }
}

// THIS METHOD CAN BE USED TO UPDATE THE ARRAY HOLDING COORDINATES FROM THE LOCAL DATABASE
private void updateFromDatabase(){
    //mCoordinatesArray.clear();
    mCoordinatesArray = mDatabase.getEntireDatabase();
    adapter.notifyDataSetChanged();
}

}

Here's my Helper class, just in case, but I don't think the problem is here.

public class LocationBaseHelper extends SQLiteOpenHelper {

private static final int VERSION = 1;
private static final String D​A​T​A​B​A​S​E​_​N​A​M​E​ = "locationBase.db";

public LocationBaseHelper(Context context) {
    super(context, D​A​T​A​B​A​S​E​_​N​A​M​E​, null, VERSION);
}

@Override
public void onCreate(SQLiteDatabase db) {
    db.execSQL("create table " +    LocationTable.NAME              + " ("      +
                                    LocationTable.Cols.DATE_TIME    + " text, " +
                                    LocationTable.Cols.LATITUDE     + " text, " +
                                    LocationTable.Cols.LONGITUDE    + " text )"
    );
}

@Override
public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {

}

public void insertEntry(String date_time, String latitude, String longitude){
    SQLiteDatabase db = this.getWritableDatabase();
    ContentValues content = new ContentValues();
    content.put(LocationTable.Cols.DATE_TIME,date_time);
    content.put(LocationTable.Cols.LATITUDE,latitude);
    content.put(LocationTable.Cols.LONGITUDE,longitude);
    db.insert(LocationTable.NAME,null,content);
}

public ArrayList<String> getEntireDatabase(){
    SQLiteDatabase db = this.getReadableDatabase();
    Cursor cursor = db.rawQuery("SELECT * FROM " + LocationTable.NAME,null);
    cursor.moveToFirst();

    ArrayList<String> values = new ArrayList<>();

    do{
        String value = (String) cursor.getString(cursor.getColumnIndex(LocationTable.Cols.DATE_TIME)) + " " +
                       (String) cursor.getString(cursor.getColumnIndex(LocationTable.Cols.LATITUDE))  + " " +
                       (String) cursor.getString(cursor.getColumnIndex(LocationTable.Cols.LONGITUDE));
        values.add(0,value);

    }while(cursor.moveToNext());

    return values;
}

public String size(){
    SQLiteDatabase db = this.getReadableDatabase();
    Cursor cursor = db.rawQuery("SELECT COUNT(*) FROM " + LocationTable.NAME,null);
    cursor.moveToFirst();
    return cursor.getString(0);
}
}

Solution

By calling mCoordinatesArray = mDatabase.getEntireDatabase(); you are changing the reference of mCoordinatesArray, and adapter is still holding the old reference, so it does not see any changes.

Instead of creating new instance of mCoordinateArray, you should rather just update values it contains, something like:

mCoordinateArray.clear();
mCoordinateArray.addAll(mDatabase.getData());
adapter.notifyDataSetChange();

That way you are changing the data that is referenced by adapter, instead of creating completely new set of data which the adapter is not aware of.

Answered By - SadClown